...
No | Category | Problem | Source Files | Suggested by | Leads | Comments |
---|---|---|---|---|---|---|
1. | Source tree | * Move the various git submodules into third-party/ or similar so it's simpler to see what is Apache original source when we review a release. | submodules | Henri Yandell | Haibin Lin | |
2. |
|
|
|
| ||
3. |
|
|
| Henri Yandell | Meghna Baijal | PR Merged |
4. | Comments | * Comment added to CODEOWNERS to explain the file so we don't cause community problems | CODEOWNERS | Henri Yandell | Steffen Rochel | |
5. | LICENSE | * There was a suggestion to simplify the LICENSE to not explicitly list which packages are under each license. Something to consider. | LICENSE | Henri Yandell | Meghna Baijal | If this is done, it would resolve points 8-11 and 13-19 of this wiki |
LICENSE | * Update the Paths to license files once submodules are moved | LICENSE | Meghna Baijal | Haibin Lin | ||
Automated Check | * Update the license_header.py script instead of manual exclusions | tools/license_header.py | Meghna Baijal | Meghna Baijal | makefiles, | |
ISSUES IN SPECIFIC FILES | ||||||
6. | Specific Files | * Resolve License Header - if you follow the URL mentioned in the file it is unclear if the code came form that site or was written for the project by the author of that site. | example/image-classification/predict-cpp/image-classification-predict.cc
| Justin McClean | ||
7. | Specific Files |
|
|
| Meghna Baijal | Possibly RAT got confused by the matching string. Does not need a fix. |
8. | Specific Files |
|
|
| Meghna Baijal | Added to MIT license in LICENSE |
9. | Specific Files | Justin McClean | Meghna Baijal | Files licenses under different licenses, added to all in the top level LICENSE - /incubator-mxnet/example/rcnn/LICENSE | ||
10. | Specific Files | Justin McClean | Meghna Baijal | Files licenses under different licenses, added to all in the top level LICENSE - /incubator-mxnet/example/rcnn/LICENSE | ||
11. | Specific Files | Justin McClean | Meghna Baijal | Files licenses under different licenses, added to all in the top level LICENSE - /incubator-mxnet/example/rcnn/LICENSE | ||
12. | Specific Files | * Missing License Header - is it Apache License? | perl-package/AI-NNVMCAPI/Makefile.PL | Justin McClean | ||
13. | Specific Files |
|
| Justin McClean | Wrongly Named in the LICENSE file as Warp-CTC, corrected | |
14. | Specific Files |
|
| Justin McClean | Wrongly Named in the LICENSE file as Warp-CTC, corrected | |
15. | Specific Files | * Add to LICENSE - BSD license | nnvm/tvm/dmlc-core/cmake/Modules/FindCrypto.cmake | Justin McClean | Meghna Baijal | Repeat again for the same file?? |
16. | Specific Files |
|
| Justin McClean | Already there in LICENSE file as MS coco | |
17. | Specific Files |
|
| Justin McClean | Already there in LICENSE | |
18. | Specific Files |
|
| Justin McClean | Added to LICENSE as BSD | |
19. | Specific Files |
|
| Justin McClean | CUB exists as BSD | |
20. | Specific Files | * Incorrect License Header - Has ASF header but is it BSD | prepare_mkl.sh | Justin McClean | Does not say BSD, add? | |
21. | Specific Files | * Incorrect License Header - Has ASF header but is it BSD | src/operator/nn/im2col.h | Justin McClean | Created PR, in review | |
22. |
| * Incorrect License Header - Has ASF header but is it BSD |
| Justin McClean | First was fixed for 1.0.0 here - https://github.com/apache/incubator-mxnet/pull/9170 | |
23. | Specific Files | * Incorrect License Header - Has ASF header but is it BSD | src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpuenums.h | Justin McClean | License seems to be correct. No ASF header. | |
24. | Specific Files | * Incorrect License Header - Has ASF header but is it BSD | example/ssd/dataset/pycocotools/coco.py | Justin McClean | Removed ASF header in PR | |
25. | Specific Files | * Incorrect License Header - Has ASF header but is it MIT | example/rcnn/rcnn/cython/setup.py | Justin McClean | Removed ASF Header in PR | |
26. | Specific Files | * Incorrect License Header - Has ASF header but is it MIT | example/rcnn/rcnn/cython/nms_kernel.cu | Justin McClean | Removed ASF Header in PR | |
27. |
|
|
| Justin McClean | Repeat | |
Specific Files | Resolve License: should this file get an apache license? (RAT thinks so but why does the script skip it?) | src/operator/special_functions-inl.h | ||||
APACHE RAT CHECK FAILURES | ||||||
28. | RAT Failure | * Fix Submodules - RAT detected almost 2000 files with unknown licenses in submodules | Submodules (nnvm, dlpack, 3rdparty, ps-lite, mshadow) and R-package | Decision needed on how to handle submodule licenses | ||
29. | RAT Failure | * Check Docs - RAT detected almost 200 files with unknown licenses in the Docs directory | /docs | Excluded for now | ||
30. | RAT Failure | * Fix dockerfiles without license headers | /docker | Meghna Baijal | Added a top level License.md to this folder | |
31. | RAT Failure | * Fix docker_multiarch - unknown license header | /docker_multiarch | Meghna Baijal | Added a top level License.md to this folder | |
32. | RAT Failure | * Fix scala-package - unknown license | /scala-package | Added apache license | ||
33. | RAT Failure | * Fix tools | /tools | |||
34. | RAT Failure | * Fix tests | /tests | All fixed except one `tests/ci_build/pylintrc` | ||
35. | RAT Failure | * Fix examples | /examples | |||
37. | RAT Failure | * Fix ctc_include | src/operator/contrib/ctc_include | |||
F. Static Linked Dependencies in Release
This section lists all dependencies used in the releases of pip and maven. Frank Liu pointed out some of them are using BSD3, GPL and customized License which should be placed in the official releases.
current stable version | binary release for ubuntu 16.04 | mxnet release 1.4 | build flag | Build dependencies | License | License Name | ||||
OpenBLAS | 0.2.20 | 0.2.18 | 0.3.2 | make -j $(nproc) DYNAMIC_ARCH=1 NO_SHARED=1 USE_OPENMP=1 | https://github.com/xianyi/OpenBLAS/blob/develop/LICENSE | BSD3 | ||||
OpenCV | 4.0.0 | 2.4.9.1 | 3.4.2 | cd build && cmake -q -D OPENCV_ENABLE_NONFREE=OFF -D WITH_1394=OFF -D WITH_ARAVIS=OFF -D WITH_AVFOUNDATION=OFF -D WITH_CAROTENE=OFF -D WITH_CLP=OFF -D WITH_CSTRIPES=OFF -D WITH_CPUFEATURES=OFF -D WITH_CUBLAS=OFF -D WITH_CUDA=OFF -D WITH_CUFFT=OFF -D WITH_DIRECTX=OFF -D WITH_DSHOW=OFF -D WITH_EIGEN=ON -D WITH_FFMPEG=OFF -D WITH_GDAL=OFF -D WITH_GDCM=OFF -D WITH_GIGEAPI=OFF -D WITH_GPHOTO2=OFF -D WITH_GSTREAMER=OFF -D WITH_GSTREAMER_0_10=OFF -D WITH_GTK=OFF -D WITH_GTK_2_X=OFF -D WITH_HALIDE=OFF -D WITH_IMAGEIO=OFF -D WITH_IMGCODEC_HDR=OFF -D WITH_IMGCODEC_PXM=OFF -D WITH_IMGCODEC_SUNRASTER=OFF -D WITH_INF_ENGINE=OFF -D WITH_INTELPERC=OFF -D WITH_IPP=OFF -D WITH_IPP_A=OFF -D WITH_ITT=OFF -D WITH_JASPER=OFF -D WITH_JPEG=ON -D WITH_LAPACK=ON -D WITH_LIBREALSENSE=OFF -D WITH_LIBV4L=OFF -D WITH_MATLAB=OFF -D WITH_MFX=OFF -D WITH_MSMF=OFF -D WITH_NVCUVID=OFF -D WITH_OPENCL=OFF -D WITH_OPENCLAMDBLAS=OFF -D WITH_OPENCLAMDFFT=OFF -D WITH_OPENCL_SVM=OFF -D WITH_OPENEXR=OFF -D WITH_OPENGL=OFF -D WITH_OPENMP=OFF -D WITH_OPENNI=OFF -D WITH_OPENNI2=OFF -D WITH_OPENVX=OFF -D WITH_PNG=ON -D WITH_PROTOBUF=OFF -D WITH_PTHREADS_PF=ON -D WITH_PVAPI=OFF -D WITH_QT=OFF -D WITH_QTKIT=OFF -D WITH_QUICKTIME=OFF -D WITH_TBB=OFF -D WITH_TIFF=ON -D WITH_UNICAP=OFF -D WITH_V4L=OFF -D WITH_VA=OFF -D WITH_VA_INTEL=OFF -D WITH_VFW=OFF -D WITH_VTK=OFF -D WITH_WEBP=OFF -D WITH_WIN32UI=OFF -D WITH_XIMEA=OFF -D WITH_XINE=OFF -D BUILD_ANDROID_EXAMPLES=OFF -D BUILD_ANDROID_PROJECTS=OFF -D BUILD_ANDROID_SERVICE=OFF -D BUILD_CUDA_STUBS=OFF -D BUILD_DOCS=OFF -D BUILD_EXAMPLES=OFF -D BUILD_FAT_JAVA_LIB=OFF -D BUILD_IPP_IW=OFF -D BUILD_ITT_IW=OFF -D BUILD_JAVA=OFF -D BUILD_JASPER=OFF -D BUILD_JPEG=OFF -D BUILD_OPENEXR=OFF -D BUILD_PACKAGE=OFF -D BUILD_PERF_TESTS=OFF -D BUILD_PNG=OFF -D BUILD_SHARED_LIBS=OFF -D BUILD_TBB=OFF -D BUILD_TESTS=OFF -D BUILD_TIFF=OFF -D BUILD_WEBP=OFF -D BUILD_WITH_DEBUG_INFO=OFF -D BUILD_WITH_DYNAMIC_IPP=OFF -D BUILD_WITH_STATIC_CRT=OFF -D BUILD_ZLIB=OFF -D BUILD_opencv_apps=OFF -D BUILD_opencv_aruco=OFF -D BUILD_opencv_calib3d=OFF -D BUILD_opencv_contrib=OFF -D BUILD_opencv_dnn=OFF -D BUILD_opencv_features2d=OFF -D BUILD_opencv_flann=OFF -D BUILD_opencv_gpu=OFF -D BUILD_opencv_gpuarithm=OFF -D BUILD_opencv_gpubgsegm=OFF -D BUILD_opencv_gpucodec=OFF -D BUILD_opencv_gpufeatures2d=OFF -D BUILD_opencv_gpufilters=OFF -D BUILD_opencv_gpuimgproc=OFF -D BUILD_opencv_gpulegacy=OFF -D BUILD_opencv_gpuoptflow=OFF -D BUILD_opencv_gpustereo=OFF -D BUILD_opencv_gpuwarping=OFF -D BUILD_opencv_highgui=OFF -D BUILD_opencv_java=OFF -D BUILD_opencv_js=OFF -D BUILD_opencv_ml=OFF -D BUILD_opencv_ml=OFF -D BUILD_opencv_nonfree=OFF -D BUILD_opencv_objdetect=OFF -D BUILD_opencv_photo=OFF -D BUILD_opencv_python=OFF -D BUILD_opencv_python2=OFF -D BUILD_opencv_python3=OFF -D BUILD_opencv_superres=OFF -D BUILD_opencv_video=OFF -D BUILD_opencv_videoio=OFF -D BUILD_opencv_videostab=OFF -D BUILD_opencv_viz=OFF -D BUILD_opencv_world=OFF -D OpenBLAS_HOME=/mxnet/mxnet-distro/deps -D OpenBLAS_INCLUDE_DIR=/mxnet/mxnet-distro/deps/include -D OpenBLAS_LIB=/mxnet/mxnet-distro/deps/lib/libopenblas.a -D LAPACK_INCLUDE_DIR=/mxnet/mxnet-distro/deps/include -D LAPACK_LINK_LIBRARIES=/mxnet/mxnet-distro/deps/lib/ -D LAPACK_LIBRARIES=/mxnet/mxnet-distro/deps/lib/libopenblas.a -D LAPACK_CBLAS_H='cblas.h' -D LAPACK_LAPACKE_H='lapacke.h' -D LAPACK_IMPL='OpenBLAS' -D HAVE_LAPACK=1 -D OPENCV_LIB_INSTALL_PATH=lib -D OPENCV_INCLUDE_INSTALL_PATH=include -D CMAKE_LIBRARY_PATH=lib -D CMAKE_INCLUDE_PATH=include -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=build/opencv .. | eigen, libpng, libjpg-turbo, libtiff, zlib | https://github.com/opencv/opencv/blob/master/LICENSE | BSD3 | |||
zlib | 1.2.11 | 1.2.8 | 1.2.6 | cd build && cmake -q -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/mxnet/mxnet-distro/deps -D BUILD_SHARED_LIBS=OFF .. | https://github.com/LuaDist/zlib/blob/master/README | |||||
libjpeg-turbo | 2.0.1 | 1.5.3-62 | 1.5.90 (2.0 beta 1) | cd build && cmake -q -G"Unix Makefiles" -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/mxnet/mxnet-distro/deps -D CMAKE_C_FLAGS=-fPIC -D WITH_JAVA=FALSE -D WITH_JPEG7=TRUE -D WITH_JPEG8=TRUE -D ENABLE_SHARED=FALSE .. | nasm | https://github.com/libjpeg-turbo/libjpeg-turbo/blob/master/LICENSE.md | ||||
libpng | 1.6.36 | 1.2.54 | 1.6.34 | cd build && cmake -q -D PNG_SHARED=OFF -D PNG_STATIC=ON -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/mxnet/mxnet-distro/deps -D CMAKE_C_FLAGS=-fPIC .. | zlib | https://github.com/glennrp/libpng/blob/libpng16/LICENSE | ||||
libtiff | v4.0.10 | 4-0-6 | 4-0-9 | ./configure —quiet —disable-shared —disable-jpeg —disable-zlib —disable-jbig —disable-lzma —prefix=build/libtiff | https://gitlab.com/libtiff/libtiff/blob/master/COPYRIGHT | |||||
libssl-dev | 1.1.1a | 1.0.2g | 1.0.2l | ./Configure no-shared no-zlib —prefix=build/openssl —openssldir=ssl linux-x86_64 | https://github.com/openssl/openssl/blob/master/LICENSE | Apache2 | ||||
libcurl | 7.62.0 | 7.47.0 | 7.61.0 | ./configure —with-zlib —with-nghttps2 —without-zsh-functions-dir —without-librtmp —without-libssh2 —disable-debug —disable-curldebug —enable-symbol-hiding=yes —enable-optimize=yes —enable-shared=no —enable-http=yes —enable-ipv6=yes —disable-ftp —disable-ldap —disable-ldaps —disable-rtsp —disable-proxy —disable-dict —disable-telnet —disable-tftp —disable-pop3 —disable-imap —disable-smb —disable-smtp —disable-gopher —disable-manual —prefix=build/libcurl | libtool, automake | https://curl.haxx.se/docs/copyright.html | ||||
eigen | 3.3.5 | 3.2.92 | 3.3.4 | cd build && cmake -q -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=build/eigen | https://github.com/eigenteam/eigen-git-mirror/blob/master/COPYING.BSD | BSD | ||||
protobuf | 3.6.1 | 2.6.1 | 3.5.1 | ./autogen.sh && ./configure -prefix= | https://github.com/protocolbuffers/protobuf/blob/master/LICENSE | |||||
cityhash | 1.1.1 | 1.1.1 | ./configure -prefix=build/cityhash —enable-sse4.2 && make -j $(nproc) CXXFLAGS='-g -O3 -msse4.2' | https://github.com/google/cityhash/blob/master/COPYING | ||||||
zmq | 4.2.5 | 4.1.4 | 4.2.2 | cd build && cmake -q -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=build -D WITH_LIBSODIUM=OFF -D BUILD_SHARED_LIBS=OFF .. | https://github.com/zeromq/libzmq/blob/master/COPYING | GPL | ||||
lz4 | v1.8.3 | r131 | r130 | make -j $(nproc) | https://github.com/lz4/lz4/blob/dev/LICENSE | |||||
OpenCV depends on following libraries, and can build them on the fly:
- OpenBLAS
- zlib (ver 1.2.6)
- libjpeg-turbo (ver 1.5.90)
- libpng (ver 1.6.34)
- libtiff (ver 42 - 4.0.9)
- eigen (ver 3.3.4)
ps-lite dependencies (USE_DIST_KVSTORE):
- zeromq - 4.1.4
- protobuf 2.5.0
- lz4
- cityhash
USE_S3
- libcurl
- libssl-dev