Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: debated line was removed

...

  • If the author of the pull request is not a committer, a committer must be the one to approve the change.
  • If the author of the pull request is a committer, approval from their chosen reviewer is enough. A committer is trusted to choose an appropriate reviewer, even if the reviewer is not a committer.
  • Code modifications cannot be approved by silence: the patch should be committed if and only if committer is confident with the changes.

Once a pull request is approved, any committer can merge it.

...