Versions Compared

Old Version 5

changes.mady.by.user ASF Infrabot

Saved on

compared with

New Version 6

changes.mady.by.user ASF Infrabot

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: These look like trivial patches – right ?

...

Wiki Markup
The patch is then \[http://incubator.apache.org/learn/voting.html voted\] upon, and if gets a \[http://incubator.apache.org/learn/glossary.html#ConsensusApproval consensus approval\] and is not \[http://incubator.apache.org/learn/glossary.html#Veto vetoed\], can be applied to the tree. Votes should generally be permitted to run for at least 24 hours to provide an opportunity for all concerned persons to participate regardless of their geographic locations. "Consensus approval" refers to a vote which has completed with at least three binding +1 votes and no -1 vetos. The author of a patch is allowed to vote as long as they're a committer.

Non-trivial Trivial patches include:

  • documentation
  • finishing off pre-existing T_ tests
  • non-controversial non-semantic style changes (fixing indentation, adding comments, but not actual code)
  • very simple, non-controversial, and absolutely safe bug fixes (i.e.: removing repetitive my() enclosing sections)

...