Page History

...

This page is definitely in-progress.

Commit-Then-Review

Wiki MarkupC-T-R mode is short for "\[http://incubator.apache.org/learn/glossary.html#CommitThenReview Commit-then-Review\]". This is the standard development mode that we operate in. It means that committers may commit patches to the development tree without the code/rules/etc being reviewed by other committers first. Typically SVN trunk is in C-T-R mode until a new release is approaching. We then switch to R-T-C mode (see below) for the final development up to release, to stabilise the codebase.

Review-Then-Commit

Wiki MarkupR-T-C mode is short for "\[http://incubator.apache.org/learn/glossary.html#ReviewThenCommit Review-then-Commit\]".

Non-trivial patches (see below for a definition of what's considered a 'trivial' change) must be reviewed by committers, and need consensus approval before being committed into the development tree. This is done by opening a Bugzilla ticket, setting the Target Milestone to the correct release version of the tree, attaching the suggested patch to the ticket via the web interface, and putting the ticket in "review" status (indicated by adding {{\[review\]}} as a prefix to the ticket summary).

The patch is then \[http://incubator.apache.org/learn/voting.html voted\] upon, and if gets a \[http://incubator.apache.org/learn/glossary.html#ConsensusApproval consensus approval\] and is not \[http://incubator.apache.org/learn/glossary.html#Veto vetoed\], can be applied to the tree. Votes should generally be permitted to run for at least 24 hours to provide an opportunity for all concerned persons to participate regardless of their geographic locations. "Consensus approval" refers to a vote which has completed with at least three binding +1 votes and no -1 vetos.

The author of a patch is allowed to vote as long as they're a committer. Typically, if a committer uploaded the patch, it's assumed they're implicitly voting +1 on their own patch, unless otherwise specified.

...