...

Given the latest improvements with regard to time tracking, it seems appropriate to rename this class to `UsePartitionTimeOnInvalidTimestamp`, as we now have fixed definition of partition time, and also passed partition time in extract method of class ExtractRecordMetadataTimestamp.

Public Interfaces

Interface TimeStampExtractor won't have any effects UsePreviousTimeOnInvalidTimeStamp will be deprecated if class name is changed from UsePreviousTimeOnInvalidTimeStamp to UsePartitionOnInvalidTimeStamp won't change the functionality to return the highest extracted valid timestamp of the current records partition. .

Image Added

Image Added

Proposed Changes

Previously, in Kafka 2.3 we had public long onInvalidTimestamp(ConsumerRecord<Object,Object> record, long recordTimestamp, long previousTimestamp) and  public long extract(ConsumerRecord<Object,Object> record, long previousTimestamp) in UsePreviousTimeOnInvalidTimestampthe following methods inside 'UsePreviousTimeOnInvalidTimestamp' 

Image Added

Image Added

but now if we see the source code present at trunk, extract function has already but now extract has been removed from 'UsePreviousTimeOnInvalidTimestamp', currently it implements onInvalidTimestamp which is abstract method of super class  ExtractRecordMetadataTimestamp and also the argument long previousTimestamp has been changed to long partitionTime

so it seems reasonable for us to change the class name to change as main functionality of this class is to return the record partition.

...