Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

1. PoolManager is hard to mock because it consists of static methods
2. Being a static singleton with state, PoolManager locks the client into only having one PoolManager and associated ClientCache.
3. The lifecycle of Pools in the PoolManager is strange, they can be created before or after the ClientCache, but they are destroyed when the ClientCache is destroyed.

The solution is to deprecate the static PoolManager and move the Pool management related code to scoped a PoolService that is tied to a ClientCache.

Anti-Goals

...