Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

No impact

Rejected Alternatives

  1. Use request.timeout.ms to time out the socket connection at the client level instead of the network client level

      Rejected reasons:

        1. request.timeout.ms is at the client / request level. We need one in the NetworkClient level to control the connection states.
        2. The socket connection timeout should be relatively shorter than the request timeout. It's good to have a separate config.
      1. Add a new connection state TIMEOUT besides DISCONNECTED, CONNECTING, CHECKING_API_VERSIONS, READY, and AUTHENTICATION_FAILED
        1. We don't necessarily need to differentiate the timeout and disconnected states.