Versions Compared

Old Version 72

changes.mady.by.user Radar Lei

Saved on

compared with

New Version 73

changes.mady.by.user Wan Chiyang

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: update git.apache new link

...

...

Please report any errors or omissions to the HAWQ Mailing lists section. 


Coding conventions

HAWQ follows the PostgreSQL coding conventions: http://www.postgresql.org/docs/9.1/static/source.html

...

Now you can go to your own github fork to create pull requests for code review (https://github.com/changleicn/hawq). Choose the master branch of  https://github.com/apache/hawq as the base for code review. After your code is merged to Apache Repo by HAWQ committers, please close your pull request.

 


Code review

We expect that pull requests which have been submitted on github will be reviewed by committers, but will be visible to the community for comments as well. Contributors should learn the code review criteria in order to make the changes accepted.

 Code review criteria

  • Features should have a lot of potential use cases and benefit a lot of users

  • Fixes should fix the root cause of the problem
  • Easily tested and have tests associated with the commits
  • Changes have been discussed on JIRA and have a JIRA linked to your change(Pull Request)
  • Code follows the coding conventions
  • Do not introduce potential performance regressions

...