Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents


Status

Current state: Under Discussion

...

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

We support a new type of OffsetSpce in KIP-734 which is max-timestamp, and it's preferable to extend it to GetOffsetShell. In the future, maybe more OffsetSpce types will be added to it. 

Currently, we use KafkaConsumer to get offsets in GetOffsetShell, whereas the new OffsetSpec is only supported in AdminClient, so we need to change the client from KafkaConsumer to AdminClient.

Public Interfaces

Change  --command-configparameter in GetOffsetShell from property file of KafkaConsumer Client to property file of AdminClient.

Proposed Changes

  1. Support max timestamp in GetOffsetShell 
  2. Support All AdminClient config in the file specified by --command-config, the only new config is retries , which means we will resend any request that fails when getting offsets.
  3. Some old KafkaConsumer config will be ignored, for example, key.deserializer and value.deserializer

Compatibility, Deprecation, and Migration Plan

Those consumer configs which can't work with admin config will be ignored, and the only mandatory config in AdminClient is bootstrap.servers, which is also mandatory in KafkaConsumer, so this is a compatible change

Rejected Alternatives

No