Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents


Status

Current state: Under Discussion

Discussion thread: here [TBA]

JIRA: here [TBA]

Motivation

Currently there is a way to pass a KafkaClientSupplier  in KafkaStreams  constructor. This KIP proposes to add a public config in StreamsConfig  to pass the class through config and use reflection to create 

...

use a customized KafkaClientSupplier , they may still need to add required dependencies.

Public Interfaces

We will add a public field in StreamsConfig  called streams.kafka.client.supplier to configure the KafkaClientSupplier  we use in KafkaStreams .

Proposed Changes

In KafkaStreams  constructor, we will read the value of streams.kafka.client.supplier from StreamsConfig  and if it's not null  and not empty, we will use reflection to create an object of given class and throw

an exception if the class type isn't  KafkaClientSupplier .

Compatibility, Deprecation, and Migration Plan

There will be no compatibility, deprecation and migration issues.

Test Plan

Unit test can capture the changes in this KIP. We can test happy path where object can be created successfully and exception case where class couldn't be found or type is wrong.

Rejected Alternatives

An alternative is that we don't need this change and user can use KafkaStreams  constructor to supply any KafkaClientSupplier  since it's a public constructor.

...