Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • When set to requested, MirrorMaker will use the IncrementalAlterConfigs for syncing topic configurations. If it receives an error from an incompatible broker, will use the deprecated the alterConfigs API  AlterConfigs API instead. It will also log a WARN message that says "The target cluster <ALIAS> is not compatible with IncrementalAlterConfigs API. Therefore using deprecated AlterConfigs API for syncing topic configurations. ". 

...

  • When explicitly set to required, MirrorMaker will use the IncrementalAlterConfigs API for syncing topic configurations. If it receives an error from an incompatible broker, the MirrorMaker will report this to the user and fail the connector. It will log an error that says "The target cluster <ALIAS> is not compatible with IncrementalAlterConfigs API for syncing topic configurations. The API requires Kafka 2.3.0 or later". 

3) Update syncTopicConfigs()  in MirrorSourceConnector.java to call the updateTopicConfigsUsingIncrementalAlterConfigs() instead of updateTopicConfigs() if enable.incremental.alter.configs is set to true.

...

  • We could have changed the current updateConfigs() method to call describeConfigs DescribeConfigs API before alterConfigs  AlterConfigs so that it had an incremental mode. This would have avoided the migration, however, the topics configurations could change between describeConfigs  DescribeConfigs and alterConfigs  AlterConfigs calls so we could still end up syncing incorrect topic configurations. We would need to stop using the deprecated API at some point anyway.