Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Fix the implementation to handle seprator before class name for internal topics

...

Code Block
languagejava
public class DefaultReplicationPolicy implements ReplicationPolicy, Configurable {

	private Boolean isInternalTopicSeparatorEnabled;
	
    @Override
    public void configure(Map<String, ?> props) {
        if (props.containsKey(INTERNAL_TOPIC_SEPARATOR_ENABLED_CONFIG)) {
            isInternalTopicSepratorEnabled = (Boolean) props.get(INTERNAL_TOPIC_SEPRATOR_ENABLED_CONFIG);
        }
    }
    private String internalSuffix() {
        return internalSeparator() + "internal";
    }     
    
    private String internalSuffix() {
        return isInternalTopicSeparatorEnabled ? separator internalSuffix() + "internal";
    }
	
    private String checkpointsTopicSuffix() {
        return internalSeparator() + "internalcheckpoints" : ".internal" + internalSuffix();
    }

    @Override
    public String offsetSyncsTopic(String clusterAlias) {
        return "mm2-offset-syncs" + internalSeparator() + clusterAlias + internalSuffix();
    }
 
}

Backporting plan

  • The KIP need to be released as part of the bugfix release to the last 3 versions
  • The KIP need to be backported into 3.1 and 3.2 (any other version reached EOL post KIP-690).  

...