Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Look for typical pitfalls: Read through the implementation to see if: it needs to be documented at places where the intention is not clear; if all the boundary conditions are being addressed; if the code is defensive enough; if any bad idioms have leaked in such as double check locking etc. In short, check for thinks things that a developer is likely to miss in their own code which are otherwise obvious to someone trying to read and understand the code.

...