Versions Compared

Old Version 3

changes.mady.by.user John Sichi

Saved on

compared with

New Version 4

changes.mady.by.user John Sichi

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Visit https://reviews.facebook.net and connect your existing github or Facebook account there.
  2. The Phabricator command-line tool arc requires a PHP interpreter available on your development machine.  If you can run the command php --version, you already have it.  If not, google for "php command line" to see how to install it for your system.
  3. Next, install arc.
  4. In your Hive checkout (either git or svn), run arc install-certificate and follow the instructions given.
  5. Run ant arc-setup to install an extra module needed for JIRA integration.  (This ant target was added with the commit of HIVE-2486.)

That's it, you're ready to use Phabricator!

...

Work in progress...best to use git for now, or keep using Review Board + svn.

Reviewing Patches

When using the Differential UI to review a diff:

  • Click on a line number in code to add a line-specific comment
  • You can also add general comments in the box at the bottom
  • When done, be sure to choose an action (e.g. Request Changes) from the dropdown at the bottom, and then click the Clowncopterize button.  Without this, the contributor+JIRA won't see your changes.

Committing Patches (svn)

If you are a committer, you can apply a patch from revision D123 to be committed with:

...

For now, continue to use svn commit.  In the future we'll be using arc commit instead so that Phabricator will be able to correctly detect that the revision has been committed.

Limitations

...

  1. svn contributor support
  2. arc commit log format that will satisfy both Jenkins and Phabricator (without this, contributors need to manually mark their revisions as committed)
  3. there's currently no way for contributors to grant the ASF rights on their patch except to go to JIRA and re-add the last version of the patch there, clicking the correct radio button; we haven't thought of an acceptable solution to this, so please let us know if you have any bright ideas
  4. it would be nice to keep using the old patch naming convention, e.g. HIVE-123.1.patch instead of D23.1.patch
  5. lint, unit tests, etc