Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Repeat until all reviewers are satisfied.  Note that you only need to specify --jira on the very first call to arc diff; after that, arc will get it from the revision ID stored in the git log.

Submitting Patches (svn)

From an svn checkout (e.g. from svn checkout http://svn.apache.org/repos/asf/hive/trunkImage Added hive-trunk), a typical usage sequence is as follows:

  1. ant arc-setup
  2. edit some files to implement HIVE-123
  3. arc diff --jira HIVE-123 (you will be prompted for a description)
  4. optionally, visit diff URL provided by Phabricator to do things like add reviewers and CC's

Note that at this point, your diff has already been submitted as a patch against JIRA, along with a corresponding comment in JIRA containing a link back to the new diff.

If you just want to see what your diff looks like, without actually creating it, omit --jira on the arc diff command line.  (The svn workflow does not support the --preview option.)

At this point, reviewers can add comments and request changes.  To address them:

  1. edit some more files
  2. arc diff (you'll be prompted to pick the correct existing diff against which to apply your changes)

Unlike git, the svn workflow does not have the ability to associate the existing diff with your checkout, which is why you have to help it outWork in progress...best to use git for now, or keep using Review Board + svn.

Reviewing Patches

When using the Differential UI to review a diff:

...