Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Amazingly, it will actually svn add/remove files for you automatically, so you don't have to (as you would with a raw patch command).  Wow!  Progress!

For now, continue to use svn commit.  In the future we'll be using arc commit instead so that Phabricator will be able to automatically detect that the revision has been committed.  You can do this manually by following the svn commit with arc mark-committed 123Then to commit, run arc commit once all necessary testing has passed. This will perform an svn commit for you with the correct log message filled in automatically.

Limitations

  1. there's currently no way for contributors to grant the ASF rights on their patch except to go to JIRA and re-add the last version of the patch there, clicking the correct radio button; we haven't thought of an acceptable solution to this, so please let us know if you have any bright ideas
  2. it would be nice if submitting a diff and requesting changes automatically updated the JIRA "Patch Available" status
  3. it would be nice to keep using the old patch naming convention, e.g. HIVE-123.1.patch instead of D23.1.patch
  4. lint, unit tests, etc