Page History

This page explains how to use Phabricator for code review of contributions to Apache Hive.  Phabricator usage is currently under test; the official code review tool is still Review Board, but we're thinking about changing that, so please help test out Phabricator and let us know what you think on the Hive mailing lists.

Setup

1. Visit https://reviews.facebook.net and connect your existing github or Facebook account there.
2. The Phabricator command-line tool arc requires a PHP interpreter available on your development machine.  If you can run the command php --version, you already have it.  If not, google for "php command line" to see how to install it for your system.
3. Next, install arc.
4. Run ant arc-setup to install an extra module needed for JIRA integration.  (This ant target was added with the commit of HIVE-2486.)
5. In your Hive checkout (either git or svn), run arc install-certificate and follow the instructions given.

...

1. there's currently no way for contributors to grant the ASF rights on their patch except to go to JIRA and re-add the last version of the patch there, clicking the correct radio button; we haven't thought of an acceptable solution to this, so please let us know if you have any bright ideas're working on a solution for this
2. it would be nice if submitting a diff and requesting changes automatically updated the JIRA "Patch Available" statusit would be nice to keep using the old patch naming convention, e.g. HIVE-123.1.patch instead of D23.1.patch
3. lint, unit tests, etc