Page History

...

• Submitting a patch: To submit a patch, first make sure that you have attached it to the JIRA and changed the status of the JIRA to 'Patch Available'. If the change is non-trivial, then please also post the patch for review on review board. The commands to generate the patch are:

  Code Block
  $ svn diff > /path/to/patch-file.patch

  or

  Code Block
  $ git diff --no-prefix > /path/to/patch-file.patch

• Identify a reviewer: When posting on review board, always add the Group "Flume" to the list of reviewers. Optionally, you may also add a reviewer specifically to the review. You can pick any of the project committers for review. Note that identifying a reviewer does not stop others from reviewing your change. Be prepared for having your change reviewed by others at any time. If you have posted your change for review and no one has had a chance to review it yet, you can gently remind everyone by dropping a note on the developer mailing list with a link to the review.

...