Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

PropertiesDefaultDescription
emit.offset-syncs.enabled true

Whether to store the new offset of the replicated records in offset-syncs topic or not. MirrorCheckpointConnector will fail to start if emit.checkpoints.enabled and/or sync.group.offsets.enabled are enabled while emit.offset-syncs.enabled  are disabled.

Proposed Changes

  • Similar to emit.checkpoints.enabled 

...

  •  and emit.heartbeat.enabled   this KIP will add emit.offset-syncs.enabled . The config default value will be true to keep the current implementation.

  • offset-syncs topic will not be created if emit.offset-syncs.enabled

...

  •   set to false 

  • logic to publish offset syncs in commit()  will not be executed if emit.offset-syncs.enabled

...

  •   set to false 

  • MirrorCheckpointConnector  validation will fail at start if emit.offset-syncs.enabled

...

  •  disabled while emit.checkpoints.enabled  and/or sync.group.offsets.enabled  are enabled. 

Compatibility, Deprecation, and Migration Plan

emit.offset-syncs.enabled  is set to true by default so any existing use-cases or use-cases that run this feature will do nothing. Only use-case that wish to fully disable this feature will need to set emit.offset-syncs.enabled to false.

Rejected Alternatives

  • Reuse emit.checkpoints.enabled   and sync.group.offsets.enabled

...

  •  and assume that if both are disabled then this feature needs to be fully disabled. I didn't want to relay on MirrorCheckpointConnector

...

  •   configs to configure MirrorSourceConnector . And this might impact customers who enabled  MirrorSourceConnector  with intention to run MirrorCheckpointConnector  later in the future