Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

In general we are very conservative about changing the Apache Ambari code base. It is ground truth for systems that use it, so we need to make sure that it is reliable. For this reason we use Review Then Commit (RTC) http://www.apache.org/foundation/glossary.html#ReviewThenCommitImage Removed change policy.

...

  • make sure the code is up-to-date
    • svn update
  • apply the patch
    • patch -p0 < path_to_patch
  • run the tests are your machine as a final check.
  • edit the CHANGES.TXT file and put the jiras that correspond to the patch in the appropriate section. add the Jira number. description (contributor via committer). a convention has emerged of using the committers id for brevity, but using the full names of non-committers.
  • svn commit the changes
  • resolve (make sure you "resolve" and not "close".) the jiras that correspond to the patch and put the commit message (that one that has the new revision number) in the resolution comment field.

If the Jira is a bug fix you may also need to commit the patch to the latest branch in subversion.

...

Add Labels