Page History

...

ReviewBoard tool is a simple tool and has only 3 states ("Pending", "Submitted", "Discarded") and relies on humans to complete the workflow. Once review is posted it is in "Pending" state. The reviewers get notified by email. The reviewers evaluates the patch and provides feedback to the submitter. If the reviewer is satisfied with the patch, they should mark the patch as approved by cliking clicking on "Ship It" button.

Now this is where the reviewers need to supplement the workflow by tagging as comment

1. "Ship It: Not commited, Pending review from $Reviewer_Name" : You Reviewers should tag the review as pending another reviewer if you they are satisified with the review but want another pair of eyes to review it. There is ambiguity in which reviewer should commit the patch when there are multiple reviewers. The last person reviewing the patch and giving a "Ship It" should commit the patch but you reviewer can ask another reviewer/ committer to commit the patch.
2. "Ship It: Committed $commit_id" : Reviewer has reviewed the patch, is satisified, has committed the patch in appropriate branch". The commit id is needed to confirm that the patch has been committed.

The submitter completes the work flow once the patch has been committed by changing the state to "Submitted" manually

Responsibilities

As a Contributor

...