Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Now this is where the reviewers need to supplement the workflow by tagging as comment

  1. "Ship It: Not commitedcommitted, Pending review from $Reviewer_Name" : Reviewers should tag the review as pending another reviewer if they are satisified with the review but want another pair of eyes to review it. There is ambiguity in which reviewer should commit the patch when there are multiple reviewers. The last person reviewing the patch and giving a "Ship It" should commit the patch but reviewer can ask another reviewer/ committer to commit the patch.
  2. "Ship It: Committed $commit_id" : Reviewer has reviewed the patch, is satisified, has committed the patch in appropriate branch". The commit id is needed to confirm that the patch has been committed.

...