Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Click on the New Review Request link.
  2. Select "cloudstack-git" in the Repository dropdown, upload your diff and click "Create Review Request" to get to next page where you will enter more details in several fields
  3. In "Groups" auto-fill text field specify "cloudstack"
  4. In "People" auto-fill text field type in the name of persons who should be reviewing the patch. You can chose choose more than one person to review your patch. If you are not sure who should be reviewing your patch please check CloudStack Maintainers List By Components
  5. In "Branch" text field specify the branches your patch should be submitted to.
  6. If your patch fixes a defect specify the cloudstack jira bug id in "Bugs" text field.
  7. In "Description" field add a brief description of what your patch does
  8. In "Testing" field specify what tests were performed
  9. Click "Publish" button to submit your patch

...

ReviewBoard tool is a simple tool and has only 3 states ("Pending", "Submitted", "Discarded") and relies on humans to complete the workflow. Once review is posted it is in "Pending" state. The reviewers get notified by email. The reviewers evaluates evaluate the patch and provides provide feedback to the submitter. If the reviewer is satisfied with the patch, they should mark the patch as approved by clicking on "Ship It" button.

...

  1. "Ship It: Not committed, Pending review from $Reviewer_Name" : Reviewers should tag the review as pending another reviewer if they are satisified satisfied with the review but want another pair of eyes to review it. There is ambiguity in which reviewer should commit the patch when there are multiple reviewers. The last person reviewing the patch and giving a "Ship It" should commit the patch but reviewer can ask another reviewer/ committer to commit the patch.
  2. "Ship It: Committed $commit_id" : Reviewer has reviewed the patch, is satisifiedsatisfied, has committed the patch in appropriate branch". The commit id is needed to confirm that the patch has been committed.

...