...
What makes it "ready to merge"
- Ensure that any relevant database upgrade scripts are in place prior to the merge (and appropriate to the current master branch's version number)
- Add unit tests to new classes and methods. These should be true unit tests, which mock any external system dependencies (i.e.: no database should be required).
- Add automated integration tests (using Marvin!) or unit-style tests that may require external systems to exist, so that primary test scenarios are modeled and automated.
- A RAT report shows that there are no license header issues outstanding.
- Any new dependencies have been discussed and agreed on in the dev list.
- Legal docs updated in the branch to support any new dependencies.
- The branch has been rebased against the latest version of master, so that the differences are limited to what's expected to merge (grab the master commit-sh, so that you can point to it in the merge email).
- Test the build, run unit tests, run integration tests. Everything should be passing before moving forward with a merge proposal.
...
{"serverDuration": 104, "requestCorrelationId": "2adcc23d79ac51ad"}