Versions Compared

Old Version 25

changes.mady.by.user Muralidhar Basani

Saved on

compared with

New Version 26

changes.mady.by.user Muralidhar Basani

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Code Block
languagejava
titleMain changes
		@Deprecated
        public static final String DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG = "default.deserialization.exception.handler";
        
        @Deprecated
        public static final String DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC = "Exception handling class that implements the <code>org.apache.kafka.streams.errors.DeserializationExceptionHandler</code> interface.";

        /** {@code default.production.exception.handler} */
        @SuppressWarnings("WeakerAccess")
        @Deprecated
        public static final String DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG = "default.production.exception.handler";
        
        private static final String PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC = "Exception handling class that implements the <code>org.apache.kafka.streams.errors.ProductionExceptionHandler</code> interface.";
        
        private static final String DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC = "Exception handling class that implements the <code>org.apache.kafka.streams.errors.DeserializationExceptionHandler</code> interface.";

         /** {@code default.production.exception.handler} */
        @SuppressWarnings("WeakerAccess") 
        public static final String DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG = "deserialization.exception.handler";

        /** {@code default.production.exception.handler} */
        @SuppressWarnings("WeakerAccess")
        public static final String PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG = "production.exception.handler";

...

  1. Deprecate the below two configs in org.apache.kafka.streams.StreamsConfig
    1. default.deserialization.exception.handler
    2. default.production.exception.handler
    3. and deprecate DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC
  2. Configs to be added to org.apache.kafka.streams.StreamsConfig
    1. deserialization.exception.handler
    2. production.exception.handler
    3. and add DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC
    Rename the below _DOC
    1. DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC to PRODUCTION_EXCEPTION_HANDLER_CLASS_DOC
  3. Update all the relevant dependency classes, so that both old and new configs are supported
    1. Update ConfigDef in TopologyConfig and code blocks like isTopologyOverride(DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG, topologyOverrides)) with new configs, so that code behaves the same for both the old and new configs
    2. RecordDeserializer update handleDeserializationFailure method
  4. Mark the tests depending on old configs as deprecated and introduce new tests in the below
    1. InternalTopologyBuilderTest
    2. StreamTaskTest
    3. StreamThreadTest
  5. If user sets both old and new configs, a ConfigException to be thrown.

...