Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

JIRA: KAFKA-17876 

Motivation

The

...

metrics

...

were

...

originally

...

named

...

in

...

the

...

`kafka.<COMPONENT>`

...

format

...

but

...

were

...

unexpectedly

...

altered

...

when

...

we

...

moved

...

Java

...

classes

...

from

...

the

...

`kafka.server`

...

package

...

to

...

the

...

`org.apache.kafka.server`

...

package

...

as

...

part

...

of

...

[commit](3.7).

...

Subsequent

...

developers

...

didn’t

...

notice

...

this

...

change

...

and

...

began

...

using

...

the

...

new

...

package

...

name

...

as

...

the

...

`metricName`.

...

The

...

correct

...

naming

...

should

...

actually

...

revert

...

to

...

`kafka.<COMPONENT>`.

This

...

KIP

...

aims

...

to

...

standardize

...

Kafka

...

metric

...

naming

...

by

...

updating

...

the

...

`org.apache.kafka.server:type=AssignmentsManager`

...

metric

...

to

...

follow

...

the

...

`kafka.<COMPONENT>`

...

convention

...

used

...

by

...

other

...

Kafka

...

metrics.

...

...

Public Interface

  • org.apache.kafka.server.AssignmentsManager

Proposed Changes

Rename

...

the

...

`org.apache.kafka.server:type=

...

AssignmentsManager` metric

...

to

...

`kafka.server:type=

...

AssignmentsManager`.

...

This

...

change

...

will

...

impact

...

external

...

monitoring

...

systems

...

that

...

rely

...

on

...

this

...

metric,

...

and

...

corresponding

...

modifications

...

will

...

be

...

needed

...

to

...

support

...

the

...

new

...

name.

Compatibility, Deprecation, and Migration Plan

...

  1. Add

...

  1. new

...

  1. warn

...

  1. log

...

  1. which

...

  1. is

...

  1. "org.apache.kafka.server:type=AssignmentsManager

...

  1. will

...

  1. be

...

  1. deprecated

...

  1. in

...

  1. the

...

  1. future,

...

  1. it

...

  1. will

...

  1. rename

...

  1. to

...

  1. kafka.server:type=AssignmentsManager"

...

  1. in

...

  1. `AssignmentsManager#metricName`

...

  1. method.

...

  1. In

...

  1. the

...

  1. next

...

  1. major

...

  1. release,

...

  1. we

...

  1. will

...

  1. update

...

  1. `AssignmentsManager#metricName` method

...

  1. to

...

  1. return

...

  1. `kafka.server:type=

...

  1. AssignmentsManager`.

Test Plan

n/a

Rejected Alternatives

...