Page History

• Checkout Code from: http://git-wip-us.apache.org/repos/asf/ambari.git
• Open an Apache Jira corresponding to the internal Jira

• Please make sure you use the external jira for most of the design updates (adding detailed descriptions, comments, etc)

• Create a patch and upload to the external jira

• As soon as you think the patch is ready for review please mark the patch as Patch Available by clicking on the “Submit Patch” button

• Request one of the Ambari Team Committers to review the patch

• On review completion and any further updates, the reviewer adds a comment to the external jira approving the patch (“+1”)

• NOTE: On backend changes reviewers please make sure tests are attached to each jira. If there is special case, please make sure there is a good explanation for not having a test case.

• After the reviewer has approved the patch, the person who is assigned the jira is responsible for getting it committed to external jira - so in case you do not have commit rights please find one of your team members to do it for you.

• Use https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit on how to commit to svn

• After committing to svn, resolve the external and internal Jiras as Fixed.

CV Patches:

• See https://docs.google.com/a/hortonworks.com/document/d/1pvWfDDNv_DHH0ZHCBblZvux7i-TX_Pmtzx7R-UHXhB0/edit 

• All unit tests must pass after applying the patch.

• Also, any new files must contain Apache 2.0 license headers

• http://www.apache.org/legal/src-headers.html 

• Do not use tabs.  Set your IDE to convert tabs into spaces instead.

• Do not use non-ASCII characters

• Do not use Windows newline characters.  Use UNIX newline characters instead.

• Make sure that you are checking in all dependencies/new files; after committing, the build should work on clean checkout

• Make sure that the clock is set up correctly on your machine.

Ambari uses ReviewBoard for code reviews.

...