Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • All unit tests must pass after applying the patch.

  • Also, any new files must contain Apache 2.0 license headers

  • Do not use tabs.  Set your IDE to convert tabs into spaces instead.

  • Do not use non-ASCII characters

  • Do not use Windows newline characters.  Use UNIX newline characters instead.

  • Make sure that you are checking in all dependencies/new files; after committing, the build should work on clean checkout

  • Make sure that the clock is set up correctly on your machine.


 Review Review Process

Ambari uses ReviewBoard for code reviews.

...