Versions Compared

Old Version 18

changes.mady.by.user Daman Arora

Saved on

compared with

New Version 19

changes.mady.by.user Daman Arora

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • domain_id = NULL indicates a global provider
  • Unique constraint on (provider, domain_id) prevents duplicate registrations

Strict Scope for oauth2.enabled

The oauth2.enabled config key uses a new strictScope mode in ConfigKey.valueInScope() to prevent automatic inheritance from global to domain scope. Each domain must explicitly set oauth2.enabled=true to enable OAuth login.

Global oauth2.enabledDomain oauth2.enabledOAuth enabled for domain?
falsenot configuredNo
falsetrueYes
falsefalseNo
truenot configuredNo (no global fallback)
truetrueYes
truefalseNo


Key difference from standard ConfigKey behavior: without strict scope, an unconfigured domain inherits the global value. With strict scope, unconfigured domains return null which is treated as disabled. This ensures domains must explicitly opt in to OAuth.

Implementation Details

  • New overload: ConfigKey.valueInScope(Scope scope, Long id, boolean strictScope)
  • Existing valueInScope(Scope, Long) delegates to new overload with strictScope=false for backward compatibility
  • When strictScope=true and no scope-specific value exists, returns null instead of walking up the parent scope hierarchy
  • All OAuth oauth2.enabled checks use: Boolean.TRUE.equals(OAuth2IsPluginEnabled.valueInScope(ConfigKey.Scope.Domain, domainId, true))