Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

We can use follow tests to cover the change:

Type\Configure

local retention time

local retention size

lag time

lag size

Expect result

 

 

 

Special cases which can help to understand the basic rule for code review

 

 

*

 *

-2 (default value)

*

No lag time check but check lag size if need

*

 *

0

*

No any delay check. 

-1

*

-1

*

Invalid configure

*

*

*

-2 (default value)

No lag size check but check lag time if need

*

*

*

0

No any delay check. 

*

-1

*

-1

Invalid configure

 

 

3 day

Typical user cases which can test with deployment

 

3 days


 

 

-1

1 day

 

-2 (default value)

lag: 1 day

-1

3 GB

-2 (default value)

No lag

1 day

-2 (default value)

lag: 1 day

-1

-2 (default value)

lag:  3 days

 

-1

 

3 GB

-2 (default value)

-2 (default value)

No lag

-2 (default value)

1 GB

lag: 1 GB

-2 (default value)

-1

lag: 3 GB

3 day

 

 

3 days

 

 

3 GB

-2 (default value)

-2 (default value)

No lag

-1

-1

lag: 3 days or 3
3
GB

1 day

1 GB

lag: 1
day
days or 1 GB


Unit Tests:

  1. Test upload eligibility logic with different configure values
  2. Test configuration validation for topic

...