Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

We can use follow tests to cover the change:

Type\Configure

local retention time

local retention size

lag time

lag size

Expect result

Notes

 

 

 

Special cases which can help to understand the basic rule for code review

 

 

-1

 *

0 (default value)

*

No lag time check but check lag size if need
3

7 days

 *

0

*

No lag 

-1

*

-1

*

Invalid configure

*

-1

*

0 (default value)

No lag size check but check lag time if need

*

3 GB

*

0

No lag 

*

-1

*

-1

Invalid configure

 

 

Typical user cases which can test with deployment


 

 

3

7 days


 

-1

 

0 (default value)

0 (default value)

No lag

Kafka defalut configure

1 day

0 (default value)

lag: 1 day

-1

0 (default value)

lag:
  3
7 days

 -1

3 GB

0 (default value)

0 (default value)

No lag 

0 (default value)

1 GB

lag: 1 GB 

0 (default value)

-1

lag: 3 GB
3
 

7 days

3 GB

0 (default value)

0 (default value)

No lag 

1 day

1 GB

lag: 1
days
day or 1 GB 

-1

-1

lag: 7 days or 3 GB 

7 days

or

3 GB

1 day

0 (default value)

No lagif check delay lag. it will break the size-based policy.

Unit Tests:

  1. Test upload eligibility logic with different configure values
  2. Test configuration validation for topic

...