Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Type\Configure

Case Id

local retention time

local retention size

lag time

lag size

Expect result

Notes

 

 

 

Special cases which can help to understand the basic rule for code review

 

 

1

-1

 *

0 (default value)

*

No lag time check but check lag size if needWhy not upload at once?
if so, No way to get the size-based delay when only using the size-based retention.

2

7 days

 *

0

*

No lagif have delay check on size. it may breack the time-based retention policy. so upload at once

3

-1

*

-1

*

Invalid configure

4

*

-1

*

0 (default value)

No lag size check but check lag time if need

5

*

3 GB

*

0

No lag 

6

*

-1

*

-1

Invalid configure

 

 

Typical user cases which can test with deployment


 

7

 7 days


 

-1

 

0 (default value)

0 (default value)

No lag

7days + No size limit is
Kafka defalut configure

If you want time lag delay. you only need to set time lag. no need to change size lag

1 day

0 (default value)

lag: 1 day

-1

0 (default value)

lag: 7 days

8

 -1

3 GB

0 (default value)

0 (default value)

No lag 

0 (default value)

1 GB

lag: 1 GB 

0 (default value)

-1

lag: 3 GB 

9

7 days

3 GB

0 (default value)

0 (default value)

No lag 

1 day

1 GB

lag: 1 day or 1 GB 

-1

-1

lag: 7 days or 3 GB 

10

7 days

3 GB

1 day

0 (default value)

No lagif check delay lag. it may break the size-based policy. So upload at once

Unit Tests:

  1. Test upload eligibility logic with different configure values
  2. Test configuration validation for topic

...