Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Please make sure you use the Apache JIRA for most of the design updates (adding detailed descriptions, comments, etc)

  • Create a patch and upload to the Apache JIRA.  The patch should be named AMBARI-XXXX.patch for trunk patches and AMBARI-XXXX_YYYY.patch for branch patches, where XXXX is the JIRA ID and YYYY is the name of the branch (for example, AMBARI-1234_branch-1.7.0.patch).

  • As soon as you think the patch is ready for review please mark the patch as Patch Available by clicking on the “Submit Patch” button

  • Wait for the "Hadoop QA" process to post feedback on the patch.  This typically takes 30 mins to an hour and reports back on unit test results, license header compliance, presence of new tests, etc, on the JIRA itself.

  • Once "Hadoop QA" checks pass, create a ReviewBoard for the patch and request two of the Ambari Team Committers to review the patch via the code review process below

    • Please note that if the patch is not involved - one committer should suffice

  • On review completion and any further updates, the reviewer says +1 for the patch

    • Note that there needs to be 2 +1's if you have 2 reviewers for involved codebase

  • NOTE: Please make sure tests are attached to each JIRA. If there is special case, please make sure there is a good explanation for not having a test case.

  • After the reviewer has approved the patch, the person who is assigned the JIRA is responsible for getting it committed

    • Please make sure the committer who has reviewed commits the patch to the respective branch in Ambari

  • Use https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit on how to commit

  • After committing to git, resolve the Apache Jiras as Fixed.

...