Page History

...

• Please make sure you use the Apache JIRA for most of the design updates (adding detailed descriptions, comments, etc)

• Create a patch and upload to the Apache JIRA.  The patch should be named AMBARI-XXXX.patch for trunk patches and AMBARI-XXXX_YYYY.patch for branch patches, where XXXX is the JIRA ID and YYYY is the name of the branch (for example, AMBARI-1234_branch-1.7.0.patch).

• As soon as you think the patch is ready for review please mark the patch as Patch Available by clicking on the “Submit Patch” button

• Wait for the "Hadoop QA" process to post feedback on the patch.  This typically takes 30 mins to an hour and reports back on unit test results, license header compliance, presence of new tests, etc, on the JIRA itself.

• Once "Hadoop QA" checks pass, create a ReviewBoard for the patch and request two of the Ambari Team Committers Ambari committers (more would not hurt) to review the patch via the code review process below

  • Please note that if the patch is not involved - one committer should suffice

• On review completion and any further updates, the reviewer says reviewers give +1 for the patch

  • A +1 from an Ambari committer is mandatory before any patch

  • can be committed (+1 from a non committer, though useful, does not count toward this requirement)

  • There should Note that there needs to be 2 +1's if you have 2 reviewers for involved codebasefrom Ambari committers for changes that are involved or if the patch is going into a release branch

• NOTE: Please make Be sure to include tests are attached to each JIRA. If there is special case, please make sure there is in the patch.  If tests are not applicable, provide a good explanation for not having a test case.

• After the reviewer(s) has approved the patch, the person who is assigned assignee of the JIRA is responsible for getting it committed

  • Please make sure the committer who has reviewed commits the patch to the respective branch in Ambari

  if that person is a committer.  If not, one of the reviewers needs to commit.

  • If the patch is intended to go into a release branch, make sure that the patch is committed to both the release branch and trunk.

• Refer to Use https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit on how to commit

• After committing to git, resolve the Apache Jiras JIRA as Fixed.

• All unit tests must pass after applying the patch.

• Also, any new files must contain Apache 2.0 license headers

• http://www.apache.org/legal/src-headers.html 

• Do not use tabs.  Set your IDE to convert tabs into spaces instead.

• Do not use non-ASCII characters

• Do not use Windows newline characters.  Use UNIX newline characters instead.

• Make sure that you are checking in all dependencies/new files; after committing, the build should work on clean checkout

• Make sure that the clock is set up correctly on your machine.

Review Process

Ambari uses ReviewBoard for code reviews.

...

Reviewers, after you are satisfied with the patch, mark "Ship It" through the ReviewBoard as well as add a or "+1" to the JIRA.

Apache Ambari Committers

...