Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Break your work into small, single-purpose patches if possible. It’s much harder to merge in a large change with a lot of disjoint features.
  2. Review the criteria for inclusion of patches (below).
  3. Create an issue for your patch on the Spark Project JIRA.
  4. If you are proposing a larger change, attach a design document to your JIRA first (example) and email the dev mailing list to discuss it.
  5. Submit the patch as a GitHub pull request. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Name your pull request with the JIRA name and include the Spark module or WIP if relevant.

  6. Follow the Spark Code Style Guide. Before sending in your pull request, you can run ./dev/lint-scala and ./dev/lint-python to validate the style.
  7. Make sure that your code passes the automated tests (see Automated Testing below)
  8. Add new tests for your code. We use ScalaTest for testing. Just add a new Suite in core/src/test, or methods to an existing Suite.
  9. Update the documentation (in the docs folder) if you add a new feature or configuration parameter.

...