Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

If you have not done so already, add the ASF git repository. For example, to add as the "apache" remote repository:

 

Code Block
languagebash
$ git remote add apache git://git.apache.org/incubator-reef.git

As a result, you can refer to the ASF git as "apache". An example setup, with a the GitHub mirror at upstream and a forked GitHub origin at {username}:

Code Block
languagebash
$ git remote -v
apache  git://git.apache.org/incubator-reef.git (fetch)
apache  git://git.apache.org/incubator-reef.git (push)
origin  https://github.com/{username}/incubator-reef.git (fetch)
origin  https://github.com/{username}/incubator-reef.git (push)
upstream  https://github.com/apache/incubator-reef.git (fetch)
upstream  https://github.com/apache/incubator-reef.git (push)

 

1. Create a branch on your local git repository

...

  1. Make sure the code compiles and all tests pass.
  2. If the code touches code that you suspect might break on YARN or Mesos, please test on those environments. If you don't have access to a test environment, ask on the mailing list for help.
  3. Make sure the code adheres to our coding guidelines.
  4. Make sure that the additions don't create errors in a Apache RAT check via mvn apache-rat:check

4. Rebase the branch onto current apache master

...

Code Block
languagebash
pick 7387a49 Comment for first commit
squash 3371411 Comment for second commit
squash 9bf956d Comment for third commit

Chapter 3 and Chapter 7 of the Git Book contains lots of information on what this means.

Also, please make sure that the commit message contains (in addition to the original and edited comments):

...