Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

StatusProposed

and up for discussionUnder development

Target Release

4.0

Original Authors

DaveJohnson

...

Here are the changes to be made to enable property based installation/configuration:

Change #1: New properties - DONE

database.installation = (auto|manual): if auto, Roller will prompt to create/upgrade tables

...

mail.connectionType = (jndi|properties) - choose either JNDI or properties for mail session
mail.jndiName - JNDI name to be used for mail-session if type is 'jndi'
mail.hostname: Host name of mail server to be used if type is 'properties'
mail.username: Username for mail server to be used if type is 'properties'
mail.password: Password for mail server to be used if type is 'properties'

Change #2: Change implementations of the Roller interface

...

- DONE

When creating persistence strategy, we rely on a DatabaseProvider class with this logic:

  • If JDBC connection properties present, use them
  • Save errors so we can show them later
  • Else use JNDI data-sourceSave errors so we can show them later

Change #3: Change mail sending code

...