Page History

...

• Use the Apache JIRA for posting design docs and having design discussions (adding detailed descriptions, comments, etc)

• Create a patch and upload to the Apache JIRA.  The patch should be named AMBARI-XXXX.patch for trunk patches and AMBARI-XXXX_YYYY.patch for branch patches, where XXXX is the JIRA ID and YYYY is the name of the branch (for example, AMBARI-1234_branch-1.7.0.patch).  If the patch is for a release branch, both trunk patch and branch patch must be uploaded.

• Mark the patch as Patch Available by clicking on the “Submit Patch” button

• Wait for the "Hadoop QA" process to post feedback on the patch.  This typically takes 30 mins to an hour and reports back on unit test results, license header compliance, presence of new tests, etc, on the JIRA itself.

• If "Hadoop QA" checks do not pass but you think the feedback is invalid, state the reasons why you believe it is invalid. 

• Once "Hadoop QA" checks pass (or if there's a valid reason for ignoring the checks), create a ReviewBoard for the patch (see Using Review Board section below) and request two Ambari committers (more would not hurt) to review the patch via the code review process below

  • Please note that if the patch is not involved - one committer should suffice

• On review completion and any further updates, the reviewers give +1 for the patch

  • A +1 from an Ambari committer is mandatory before any patch can be committed (+1 from a non committer, though useful, does not count toward this requirement)

  • There should be 2 +1's from Ambari committers for changes that are involved or if the patch is going into a release branch

• NOTE: Be sure to include tests in the patch.  If tests are not applicable, provide a good explanation for not having a test case.

• After the reviewer(s) has approved the patch, the assignee of the JIRA is responsible for getting it committed if that person is a committer.  If not, one of the reviewers needs to commit.

  • If the patch is intended to go into a release branch, make sure that the patch is committed to both the release branch and trunk.

• Refer to https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit on how to commit

• After committing to git, resolve the Apache JIRA as Fixed.

...

1. Click on "New Review Request"
2. Select "ambari" from the drop-down and upload a diff file
3. Go to the next page
1. Add a summary
2. Names of two reviewers (In case patch is simple and less involved - one reviewer is ok)
3. Select ambari as the group
4. Type in the Ambari JIRA id
5. Add description of the fix
6. Be sure to fill out "Testing Done" section to describe what testing has been done (e.g., tested X, Y, and Z scenarios end-to-end on a live cluster), post unit test results, etc.
7. Add a link to the ReviewBoard URL to the JIRA
   1. Go to JIRA Menu --> More --> Link --> Web Link (Link Text should be ReviewBoard)
8. [if applicable] Fill the optional fields as needed.
9. [if applicable] Add the unit test summary to the request
4. Publish the review
5. After the review is marked "Ship It" you can optionally attach the final patch to the JIRA.
6. Mark the review as closed
   1. On the ReviewBoard portal Close --> Submitted

...