Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Make library and charts pluggable (Remove hard coded code, and simulate loading libraries)
  • Fixes and code improvement
  • Bigger Test Cover
  • Scenario Tests
  • Remove unused files

 

Task List

Readme:

  •  Missing the steps: Bower install and npm install

UI:

  •  No button style (just text) when we run grunt serve
  •  Need similar width for all charts (NVD3 is smaller than others for example)
  •  Need to have meaningful legends

...

  •  After selecting a dataset, then a chart library, it will draw the chart. However if you click again on the same chart type that the one shown, there won't be any data in the chart.

Code Style:

  •  Fix trailing spaces
  •  Make code on multiple lines when html line are too long (~100-120 columns)
  •  Fix google-chart-factory indentation
  •  Fix Typos


Html reduction:

  •  Reduce HTML lines repetitions, use ng-repeat with a configuration object instead
  •  Remove unused files


Make code scalable for pluggable libraries:

  •  Remove hard coded library names etc... from javascript code. Only an Array with Library Names should be used as configuration to refer to.
  •  Include the Chart Html only when needed (ng-include of a {{library}}.html file)

...

  •  Remove the dummy Data from chart factories
  •  loadData should not be inside of ChartCtrl
  •  Change hardcoded loadChartLibrary function parameter inside the HTML: loadChartLibrary(2) -> should be loadChartLibrary($index) or (chart.name)

...