Versions Compared

Old Version 5

changes.mady.by.user Sijie Guo

Saved on

compared with

New Version 6

changes.mady.by.user Sijie Guo

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Info

Steps 4-7 could be automated using BookKeeper Patch Review ScriptTool


  1. Create local branch from master.

    Code Block
    $ git checkout -b BOOKKEEPER-XXXX


  2. Make your modifications, add tests and run the whole test suite.
  3. Commit your changes.

  4. Generate a patch.

    Code Block
    $ git format-patch --no-prefix master


  5. Upload the patch to JIRA.
  6. If the patch is non-trivial, also upload it to review board under bookkeeper-git.
  7. Click on Patch Available in JIRA to signal that the patch is ready to be reviewed.
  8. The jenkin build will build the patch and run various checks like long lines, trailing spaces, findbugs. The pre-commit build report will be posted as a comment to the ticket. Please watch the comment and address the failures observed in pre-commit job and iterator over them.

...