Versions Compared

Old Version 26

changes.mady.by.user Remi Bergsma

Saved on

compared with

New Version 27

changes.mady.by.user Remi Bergsma

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

 *Coverage may go down if code that was covered is deleted

 

Note
titleAbout LGTM

LGTM, "Looks Good To Me" is given once a reviewer of a Pull Requests gives an OK to proceed.
At least one of the reviews needs to run the Marvin integration tests and post output of a successful run. This is to prevent regression. Another review can then focus on the code itself, for example.
Should running the Marvin tests make no sense (for example when the Pull Request only changes the UI), the reviewer should post other "proof" that it worked for him, like a screenshot.

Pull Requests that fail these requirements and are merged anyway, will be reverted. 

Overview of release process

...

  • Once x.y.0 is released, master will be opened for new feature merges. The Release Managers announce this on the list (usually a few days are needed to finalise the release and prepare the branches for the next release).
  • When the new features are in, master will be frozen again, etc.
  • It is expected that the new version can go out soon, as we start off from an already stable master at the exact point the previous release was made.

...