LGTM, "Looks Good To Me" is given once a reviewer of a Pull Requests gives an OK to proceed. Please note: - At least one of the reviews needs to run the Marvin integration tests and post output of a successful run. This is to prevent regression. Another review can then focus on the code itself, for example.
Should running the Marvin tests make no sense (for example when the Pull Request only changes the UI), the reviewer should post other "proof" that it worked for him, like a screenshot .- Any LGTM without details on what the reviewer did, will not be considered in the LGTM count
- Before merging, any open questions and comments should be addressed
.- Pull Requests that fail the above requirements and are merged anyway, will be reverted
. |