THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
Review: Committers should review the pull request changes, leave comments and sigh off about whether accept the code change. (Reject/Recall/Pass)
Merge: merge the patch of the pull request and push the merged code to apache/incubbator-eagle (following process is temporary solution for manual merging, the automatic tool is under development EAGLE-84)
Code Block > git pull https://github.com/apache/incubator-eagle/ master # get latest > wget https://patch-diff.githubusercontent.com/raw/apache/incubator-eagle/pull/19.patch && git apply 19.patch # anyway you like to get the patch and apply > # review the code; run the test; > git commit # Commit with the commit MSG described below if everything looks good > git push https://github.com/apache/incubator-eagle/ master # push to upstream
Committers should follow an convention format to add appropriate commit message. The format is
Code Block EAGLE-${ticket_number} ${ticket_title} ${ticket_url} Author: ${commitercommitter} Reviewer: ${reviewer} Closes #${pr_number} from ${do_person}
- Author/Reviewer could be optional when the committer is the single reviewer.
- Author/Reviewer could be optional when the committer is the single reviewer.
- Close: Committer to close the JIRA ticket. (Pull request will be close automatically)
...