Page History

...

1. Review: Committers should review the pull request changes, leave comments and sigh off about whether accept the code change. (Reject/Recall/Pass)

2. Merge: merge the patch of the pull request and push the merged code to apache/incubbator-eagle (following process is temporary solution for manual merging, the automatic tool is under development  EAGLE-84)

   Info
   title Pre-requisite
   Committer(reviewer) should have already cloned repo from apache github git clone https://git-wip-us.apache.org/repos/asf/incubator-eagle.git

   Code Block

   > git pull git://git.apache.org/incubator-eagle.git master # get latest > wget https://patch-diff.githubusercontent.com/raw/apache/incubator-eagle/pull/19.patch && git apply 19.patch # anyway you like to get the patch and apply > # review the code; run the test; > git commit # Commit with the commit MSG described below if everything looks good > git push git://git.apache.org/incubator-eagle.git master # push to upstream

   Committers should follow an convention format to add appropriate commit message. The format should be:

   Code Block
   EAGLE-${ticket_number} ${ticket_title} ${ticket_url} Author: $@${committer} Reviewer: $@${reviewer} Closes #${pr_number} from ${do_person}

    

   • Author/Reviewer could be optional when the committer is the single reviewer.
   • For example: https://github.com/apache/incubator-eagle/commit/2076130d07aa9a31c098453c12eeae64cbda3266
     Image Added
     
     
3. Close: Committer to close the JIRA ticket. (Pull request will be close automatically)

...