THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
| Note | ||
|---|---|---|
| ||
This document is subject to change without notice. |
What’s a code review for?
...
For the reviewer it is an opportunity to learn not only about the code, but about the reviewer. Which kinds of quality does he value? What skills does he bring to the table?What kinds of problems can occur with code reviews?
What kinds of problems can occur with code reviews?
By nature a code review is an asymmetrical exchange. The code reviewee offers his work product, the reviewer offers a third and fourth eyeball. This is the main source of problems in a code review. The reviewer, out of respect for what the reviewee has done, may hesitate to point out real problems in the code. The reviewee, out of pride in his accomplishment, may find it difficult to accept legitimate well-meaning criticism. Or worse, the reviewer, out of envy that he didn’t get to make the change, may complain about features of the code that are matters of taste. The reviewee, out of insecurity, may allow himself to be pressured into making changes he doesn’t believe in.
...