THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
Page History
...
- Anyone in the community can start working on any unassigned ticket
- Before beginning working on a ticket, you should assign the ticket to yourself.
- Move the ticket to
IN PROGRESSstate. - If necessary, add comments describing the design decisions or approach you plan to take.
...
Review Process and Maintainers
- Ignite employs both Review-Then-Commit (RTC) process for most of the components and Commit-Then-Review (CTR) process.
- It is up to a committer to decide whether a change should need a review or not.
- for few ones.
- Any change that touches code or test, whether reviewed or not, must have full TeamCity CI test suite pass.
- As a guideline, trivial changes, like updates to documentation or tests, etc. should not need a review prior to committing, and often can be made directly in the master branch.
- It is strongly recommended to have non-trivial changes reviewed by at least one other committer.
...
| title | Master Branch |
|---|
...
| Info | ||
|---|---|---|
| ||
| Ignite "master" branch should always be release-ready. Please avoid any commits or merges to the "master" branch unless the whole TeamCity CI suite has passed. |
Changes to a RTC module should be reviewed at least by one maintainer for that module (which may or may not be the same as the main reviewer) before being merged.
Changes to a CTR module (CTR*) may be merged without waiting for review by a maintainer. However it's advisable to ask a maintainer of a CTR module for review and to wait for some time for his/her feedback.
| Component | Maintainers |
|---|---|
| Ignite Core (data grid, rebalancing, affinity, the rest of internals not covered below) | Semen Boikov, Alexey Goncharuk, Yakov Zhdanov, Anton Vinogradov |
| Marshalling (Binary, Optimized, JDK) | Vladimir Ozerov, Denis Magda, Alexey Goncharuk |
| Discovery & Communication SPIs | Yakov Zhdanov, Semen Boikov, Denis Magda |
| Ignite Compute API | Yakov Zhdanov, Valentin Kulichenko |
| Ignite Services API | Valentin Kulichenko |
| Ignite SQL & Text Queries | Sergey Vladykin |
| Ignite Continuous Queries | Nikolai Tikhonov, Semen Boikov |
| Build System | Anton Vinogradov |
| Hadoop Accelerator | Vladimir Ozerov, Ivan Veselovsky |
| Spark Shared RDDs | Alexey Goncharuk, Andrey Gura |
| IGFS | Vladimir Ozerov, Ivan Veselovsky |
| .Net API | Pavel Tupitsyn, Vladimir Ozerov |
| C++ API | Vladimir Ozerov, Ivan Veselovsky |
| Streamers (JMS, Flume, Kafka, etc.) CTR* | Raúl Kripalani, Roman Shtykh |
| Docker, Mesos, YARN integration | Nikolai Tikhonov, Igor Sapego |
| AWS, Google Compute Engine, JClouds integration | Denis Magda, Nikolai Tikhonov |
| OSGi integration | Raúl Kripalani, Denis Magda |
| Visor | Alexey Kuznetsov |
| WebSession & WebSession Filter | Valentin Kulichenko |
Submitting For Review
- Attach a patch, pull request url or branch name (see instructions at Workflow)
- Add comment describing what has been implemented.
- Move ticket to
PATCH AVAILABLEstate. - If there is a community member who you think should do the review, optionally assign the ticket to that person.
...
TeamCity should be forced to run all tests on created branch before review. Once tests are passed, the branch can has be reviewed by another committermodule's maintainer.
Created branch name should be attached to a JIRA ticket and the ticket status should be changed on Patch Available.
...
Overview
Content Tools
Apps