Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • If an unknown user submits a PR, then Jenkins automation will post a message to GitHub asking if it is okay to test.
    • Review the pull request. If the code is not malicious and is okay to test, post a comment jenkins, ok
  • If the author is a trusted contributor, you can add them to a white-list of known users.
  • New commits to the PR will trigger a new build. You can also trigger a retest without a new commit.
    • Post a comment comment: jenkins, retest
  • For extensive or risky changes, you may want to run a fuller set of tests.
    • Post a comment: jenkins, extra test
    • This runs additional jobs, running several suites o CDH and HDP distros, as well as full phoenix suite.

Validate Review

...

Criteria

 

The project committee (PPMC) has agreed that the following review criteria are used for contributions:

  • Code Review(s)
  • Time available for comments
  • Testing
    • Be sure that you wait for all pending tests!
    • New commits, even those that are just merging with latest master branch, trigger new test run.
  • Legal
  • Other 

...