Page History

...

1. Click on "New Review Request"
2. Select "ambari" from the drop-down and upload a diff file
3. Go to the next page
1. Add a summary
2. Names of at least two reviewers that are familiar with that code, please refer to Code Review Guidelines for a list of committers that have volunteered to review a certain code area (In case patch is simple and less involved - one reviewer is ok)
3. Select ambari as the group
4. Enter the name of the branch(es), e.g., "trunk", "branch-x.y"
5. Type in the Ambari JIRA id
6. Add description of the fix
7. Be sure to fill out "Testing Done" section to describe what testing has been done (e.g., tested X, Y, and Z scenarios end-to-end on a live cluster), post unit test results, etc.
8. Add a link to the ReviewBoard URL to the JIRA
   1. Go to JIRA Menu --> More --> Link --> Web Link (Link Text should be ReviewBoard)
9. [if applicable] Fill the optional fields as needed.
10. [if applicable] Add the unit test summary to the request
4. Publish the review
5. After the review is marked "Ship It" you can optionally attach the final patch to the JIRA.
6. Mark the review as closed
   1. On the ReviewBoard portal Close --> Submitted

...