THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
Impala is an Apache-licensed open-source SQL query engine for data stored in Apache Hadoop clusters. It is primarily developed by the core Impala engineering team at Cloudera, but we welcome contributions. This document contains some guidelines for contributing to Impala, and suggestions for the kind of contributions you can make.##
What should I contribute?
...
Report Bugs
Some of the most useful contributions to Impala are bug reports. If you discover a bug in Impala, please open a new JIRA ticket at [the Impala JIRA tracker](http://issues.cloudera.org/browse/IMPALA) (after first checking to see if the bug has already been reported).
Bug reports are best when they contain a precise description of the problem, a minimal set of steps to reproduce the issue, and a comprehensive description of your environment (what version of Impala are you running? Are you using HDFS, S3 or HBase?)###
Code
As with other open source communities, the best way to engage is to start small, by fixing some bugs or contributing small features. By doing so, you will earn a reputation as a contributor of high-quality patches, you will get to know the Impala community, and you will become familiar with our process for contribution.
...
Impala is extremely actively developed, and all parts of the code are changing quickly as we work to meet Impala’s roadmap and provide the features our customers need. We are therefore very unlikely to be able to accept large, unsolicited patches into the codebase. If you are considering undertaking a substantial piece of work, please be forewarned: we cannot guarantee that we will be able to accept it, or that we will have the time to review it. If you are unsure, please ask before you start work.###
Documentation
We also strongly encourage improvements to our developer documentation: we need better build documentation, getting started guides, style guides and more!##
How do I contribute code?
First of all, you need to sign and return an ["Individual Contributor Licensing Agreement" form](https://github.com/cloudera/Impala/wiki/Individual-Contributor-License-Agreement-(ICLA)) (or a [CCLA](https://github.com/cloudera/Impala/wiki/Corporate-Contributor-License-Agreement-(CCLA)), if you’re contributing as part of your job), which is required before we can accept and redistribute your contribution. Once this is submitted - and you only need to do it once - you are free to start contributing to Impala.###
Find
Find a JIRA that you would like to work on (or file one if you have discovered a new issue!). If no-one is working on it, assign it to yourself only if you intend to work on it shortly. Ramp-up JIRAs are a great place to look for your first patch ideas.
...
We may sometimes decide not to accept a proposed feature or bugfix. This does not mean we do not value your contribution, but more likely that we feel that it does not align with the goals of the project or it is not the right time.###
Fix
Now start coding! As you are writing your patch, please keep the following things in mind:
...
Finally, please write a good, clear commit message, with a short, descriptive title and a message that is exactly long enough to explain what the problem was, and how it was fixed. Here is a good example:> ####
| Panel | ||||
|---|---|---|---|---|
| ||||
IMPALA-1645 and IMPALA-1632: Verify Cache Directives |
...
When a table is loaded in the catalog, we will now perform a check to |
...
verify that the cache directive ID and cache replication factor is still |
...
valid and the data is current. |
...
If the cache directive does no longer exist, we issue a error message |
...
and mark the table / partition as uncached. Furthermore, the replication |
...
factor is updated with the information from the actual cache directive. |
...
In the case of insert statement there is a special situation as the |
...
catalog update is happening synchronously and will try to access the |
...
cache directive information that might be stale. Thus in this insert |
...
path, we catch the possible not found exception and reset the caching |
...
information. |
### Review
When you have a patch that you consider ready for submission, submit it to our code review tool called Gerrit (see [[Using Gerrit to submit and review patches|https://github.com/cloudera/Impala/wiki/Using-Gerrit-to-submit-and-review-patches]] for details). You’ll see an e-mail go out to the impala-dev@cloudera.org list.
...
Once a patch is considered ready to go in, the reviewer will give it the ‘+2’ mark in Gerrit, and will run the submission testing job.
If the testing job completes successfully, Gerrit will automatically submit the patch to Impala’s Github repository. Congratulations! You are now a contributor to Impala.
If the testing job does not complete successfully, you’ll see ‘Jenkins’ mark your patch with a -1, and you’ll need to work with your reviewer to fix the test failures.
...