Versions Compared

Old Version 2

changes.mady.by.user Dimitris Tsirogiannis

Saved on

compared with

New Version 3

changes.mady.by.user Dimitris Tsirogiannis

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Panel
borderStylesolid
titleIMPALA-1645 and IMPALA-1632: Verify Cache Directives

IMPALA-1645 and IMPALA-1632: Verify Cache Directives

When a table is loaded in the catalog, we will now perform a check to
verify that the cache directive ID and cache replication factor is still
valid and the data is current.

If the cache directive does no longer exist, we issue a error message
and mark the table / partition as uncached. Furthermore, the replication
factor is updated with the information from the actual cache directive.

In the case of insert statement there is a special situation as the
catalog update is happening synchronously and will try to access the
cache directive information that might be stale. Thus in this insert
path, we catch the possible not found exception and reset the caching
information.

 

...

Review

When you have a patch that you consider ready for submission, submit it to our code review tool called Gerrit (see [[Using Gerrit to submit and review patches|https://github.com/cloudera/Impala/wiki/Using-Gerrit-to-submit-and-review-patches]] for details). You’ll see an e-mail go out to the impala-dev@cloudera.org list.

As time permits, someone from the core team will review your patch. You will likely need to submit an updated patch with some changes - reply to all the comments in Gerrit at the same time (mark as ‘Done’ those suggestions that you’ve taken without further comment). This process can go back and forth for a while - please don’t be discouraged, you’ll see it happens with all patches!###

Commit

Once a patch is considered ready to go in, the reviewer will give it the ‘+2’ mark in Gerrit, and will run the submission testing job.

If the testing job completes successfully, Gerrit will automatically submit the patch to Impala’s Github repository. Congratulations! You are now a contributor to Impala

If the testing job does not complete successfully, you’ll see ‘Jenkins’ mark your patch with a -1, and you’ll need to work with your reviewer to fix the test failures.##

Developer mailing list

We maintain a mailing list at impala-dev@cloudera.org, which is the right place for Impala development discussions. Questions about using Impala still belong on the Impala user list, which is impala-user@cloudera.org.##

Further reading

This presentation called ['How to Get Your PostgreSQL Patch Accepted'](http://momjian.us/main/writings/pgsql/patch.pdf) captures a lot of our requirements - particularly the focus on starting small, getting agreement, working on the design first, ensuring proper testing and committing to good comments in the code.